Xterm system colors (0-15) are not adjusted in all custom themes

[jimhester]

These colors instead should be adjusted based on the theme, so the output matches what you get in other terminals with color theme (e.g. iTerm2) This screenshot is Solarized Light in iTerm2 (left) and RStudio (right). The difference is apparent particularly in the green and magenta colors.

It looks like the .xtermColor and .xtermBgColor properties for numbers 0-15 were not adjusted for all the themes.

e.g. the solorized colors

rstudio/src/gwt/src/org/rstudio/studio/client/workbench/views/source/editors/text/themes/solarized_light.css

Lines 176 to 206 in 0d9d49a

	.xtermBgColor0 { background-color: #2e3436; }
	.xtermColor1 { color: #cc0000 !important; }
	.xtermBgColor1 { background-color: #cc0000; }
	.xtermColor2 { color: #4e9a06 !important; }
	.xtermBgColor2 { background-color: #4e9a06; }
	.xtermColor3 { color: #c4a000 !important; }
	.xtermBgColor3 { background-color: #c4a000; }
	.xtermColor4 { color: #3465a4 !important; }
	.xtermBgColor4 { background-color: #3465a4; }
	.xtermColor5 { color: #75507b !important; }
	.xtermBgColor5 { background-color: #75507b; }
	.xtermColor6 { color: #06989a !important; }
	.xtermBgColor6 { background-color: #06989a; }
	.xtermColor7 { color: #d3d7cf !important; }
	.xtermBgColor7 { background-color: #d3d7cf; }
	.xtermColor8 { color: #555753 !important; }
	.xtermBgColor8 { background-color: #555753; }
	.xtermColor9 { color: #ef2929 !important; }
	.xtermBgColor9 { background-color: #ef2929; }
	.xtermColor10 { color: #8ae234 !important; }
	.xtermBgColor10 { background-color: #8ae234; }
	.xtermColor11 { color: #fce94f !important; }
	.xtermBgColor11 { background-color: #fce94f; }
	.xtermColor12 { color: #729fcf !important; }
	.xtermBgColor12 { background-color: #729fcf; }
	.xtermColor13 { color: #ad7fa8 !important; }
	.xtermBgColor13 { background-color: #ad7fa8; }
	.xtermColor14 { color: #34e2e2 !important; }
	.xtermBgColor14 { background-color: #34e2e2; }
	.xtermColor15 { color: #eeeeec !important; }
	.xtermBgColor15 { background-color: #eeeeec; }

colors

are the same as the xcode colors

rstudio/src/gwt/src/org/rstudio/studio/client/workbench/views/source/editors/text/themes/xcode.css

Lines 172 to 203 in b07f6cc

	.xtermColor0 { color: #2e3436 !important; }
	.xtermBgColor0 { background-color: #2e3436; }
	.xtermColor1 { color: #cc0000 !important; }
	.xtermBgColor1 { background-color: #cc0000; }
	.xtermColor2 { color: #4e9a06 !important; }
	.xtermBgColor2 { background-color: #4e9a06; }
	.xtermColor3 { color: #c4a000 !important; }
	.xtermBgColor3 { background-color: #c4a000; }
	.xtermColor4 { color: #3465a4 !important; }
	.xtermBgColor4 { background-color: #3465a4; }
	.xtermColor5 { color: #75507b !important; }
	.xtermBgColor5 { background-color: #75507b; }
	.xtermColor6 { color: #06989a !important; }
	.xtermBgColor6 { background-color: #06989a; }
	.xtermColor7 { color: #d3d7cf !important; }
	.xtermBgColor7 { background-color: #d3d7cf; }
	.xtermColor8 { color: #555753 !important; }
	.xtermBgColor8 { background-color: #555753; }
	.xtermColor9 { color: #ef2929 !important; }
	.xtermBgColor9 { background-color: #ef2929; }
	.xtermColor10 { color: #8ae234 !important; }
	.xtermBgColor10 { background-color: #8ae234; }
	.xtermColor11 { color: #fce94f !important; }
	.xtermBgColor11 { background-color: #fce94f; }
	.xtermColor12 { color: #729fcf !important; }
	.xtermBgColor12 { background-color: #729fcf; }
	.xtermColor13 { color: #ad7fa8 !important; }
	.xtermBgColor13 { background-color: #ad7fa8; }
	.xtermColor14 { color: #34e2e2 !important; }
	.xtermBgColor14 { background-color: #34e2e2; }
	.xtermColor15 { color: #eeeeec !important; }
	.xtermBgColor15 { background-color: #eeeeec; }

One theme where this does seem to have been adjusted is dracula

rstudio/src/gwt/src/org/rstudio/studio/client/workbench/views/source/editors/text/themes/dracula.css

Lines 273 to 304 in b07f6cc

	.xtermColor0 { color: #000000 !important; }
	.xtermBgColor0 { background-color: #000000; }
	.xtermColor1 { color: #FF5555 !important; }
	.xtermBgColor1 { background-color: #FF5555; }
	.xtermColor2 { color: #50FA7B !important; }
	.xtermBgColor2 { background-color: #50FA7B; }
	.xtermColor3 { color: #F1FA8C !important; }
	.xtermBgColor3 { background-color: #F1FA8C; }
	.xtermColor4 { color: #BD93F9 !important; }
	.xtermBgColor4 { background-color: #BD93F9; }
	.xtermColor5 { color: #FF79C6 !important; }
	.xtermBgColor5 { background-color: #FF79C6; }
	.xtermColor6 { color: #8BE9FD !important; }
	.xtermBgColor6 { background-color: #8BE9FD; }
	.xtermColor7 { color: #BFBFBF !important; }
	.xtermBgColor7 { background-color: #BFBFBF; }
	.xtermColor8 { color: #4D4D4D !important; }
	.xtermBgColor8 { background-color: #4D4D4D; }
	.xtermColor9 { color: #FF6E67 !important; }
	.xtermBgColor9 { background-color: #FF6E67; }
	.xtermColor10 { color: #5AF78E !important; }
	.xtermBgColor10 { background-color: #5AF78E; }
	.xtermColor11 { color: #F4F99D !important; }
	.xtermBgColor11 { background-color: #F4F99D; }
	.xtermColor12 { color: #CAA9FA !important; }
	.xtermBgColor12 { background-color: #CAA9FA; }
	.xtermColor13 { color: #FF92D0 !important; }
	.xtermBgColor13 { background-color: #FF92D0; }
	.xtermColor14 { color: #9AEDFE !important; }
	.xtermBgColor14 { background-color: #9AEDFE; }
	.xtermColor15 { color: #E6E6E6 !important; }
	.xtermBgColor15 { background-color: #E6E6E6; }

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs, per https://github.com/rstudio/rstudio/wiki/Issue-Grooming. Thank you for your contributions.

[jimhester]

This is still an outstanding issue

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs, per https://github.com/rstudio/rstudio/wiki/Issue-Grooming. Thank you for your contributions.

[jimhester]

This is still an outstanding issue

[romainfrancois]

back to test after #11637 and #11642 with the added .rs.show_xterm16() function to complement crayon::show_ansi_colors() :

[jonvanausdeln]

Verified on
2022.11.0-78

Tested several different themes and all looked at expected.