Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: new_rcrd() requires a format method #1954

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Conversation

JosiahParry
Copy link
Contributor

@JosiahParry JosiahParry commented Oct 22, 2024

Unline new_vctr(), new_rcrd() does not have a format() method. This is documented in the vignette at https://vctrs.r-lib.org/articles/s3-vector.html?q=record#record-style-objects.

However this is not discoverable from the reference page itself.

I only found the vignette after googling the error.

I would love for there to be guidance in the manual page here. This PR is merely a suggestion and is intended to provide a place to start from rather than only an issue.

R/type-rcrd.R Outdated Show resolved Hide resolved
R/type-rcrd.R Outdated Show resolved Hide resolved
@JosiahParry
Copy link
Contributor Author

Let me know if the most recent commit is sufficient.

R/type-rcrd.R Outdated Show resolved Hide resolved
@lionel- lionel- merged commit 78d9f2b into r-lib:main Oct 28, 2024
2 of 12 checks passed
@lionel-
Copy link
Member

lionel- commented Oct 28, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants