Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code difference with R package #46

Closed
zilin129 opened this issue Mar 2, 2020 · 1 comment
Closed

code difference with R package #46

zilin129 opened this issue Mar 2, 2020 · 1 comment

Comments

@zilin129
Copy link

zilin129 commented Mar 2, 2020

Hello, I found a difference between your code in Github and R package. In twdtw.R, Line 41, you compute the local weighted matrix, cm = phi * weight.fun(psi). However, in R package, that is cm = (1 - theta) * phi + theta * weight.fun(psi).
Can you please check it and see?
vwmaus added a commit that referenced this issue Mar 2, 2020
@vwmaus
Submitted to cran. Closees #46
ecfff58
@vwmaus
Copy link
Member

vwmaus commented Mar 2, 2020

GiHub version submitted to CRAN!

@vwmaus vwmaus closed this as completed Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vwmaus @zilin129