Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: coding guidelines and apply to code. #105

Closed
2 tasks done
Tracked by #132
Daanvdplas opened this issue Jul 5, 2024 · 3 comments
Closed
2 tasks done
Tracked by #132

chore: coding guidelines and apply to code. #105

Daanvdplas opened this issue Jul 5, 2024 · 3 comments
Assignees

Comments

@Daanvdplas
Copy link
Collaborator

Daanvdplas commented Jul 5, 2024

  • Change CI to cargo +nightly fmt. This brings advantages such as formatting comments and dependencies.
  • Create coding guidelines in this repo.

EDIT:

If its already included in your work please continue and we can manage both issues in your PR.

@Daanvdplas Daanvdplas changed the title refactor: check dependencies for coding guidelines refactor: coding guidelines consistency through repo Jul 24, 2024
@Daanvdplas Daanvdplas changed the title refactor: coding guidelines consistency through repo refactor: dependencies Jul 26, 2024
@Daanvdplas Daanvdplas changed the title refactor: dependencies chore: coding guidelines and apply to code. Aug 7, 2024
@evilrobot-01
Copy link
Collaborator

* [ ]  pop-api and primitives to workspace dependencies

Need to consider the effects of this when publishing to crates.io

@Daanvdplas
Copy link
Collaborator Author

Need to consider the effects of this when publishing to crates.io

That shouldn't be a problem. Have been working with ink-sandbox (crate) and it uses workspace dependencies (ref)

@Daanvdplas
Copy link
Collaborator Author

Daanvdplas commented Sep 9, 2024

Closed by #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants