feat(devnet): pop api + fungibles use case #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# This is the 1st commit message: refactor: general # This is the commit message #2: init # This is the commit message #3: begin refactor # This is the commit message #4: refactor: error handling # This is the commit message #5: tests: add error handling tests # This is the commit message #6: WIP # This is the commit message #7: finalise error handling # This is the commit message #8: refactor: easier review
Co-authored-by: Frank Bell <frank@r0gue.io>
16 tasks
evilrobot-01
force-pushed
the
daan/api
branch
from
c9cb1f0
to
d92a4c5
Compare
# Conflicts: # Cargo.lock # Cargo.toml # pop-api/Cargo.toml # primitives/Cargo.toml # primitives/src/lib.rs # primitives/src/storage_keys.rs # runtime/devnet/Cargo.toml # runtime/devnet/src/config/assets.rs # runtime/devnet/src/config/contracts.rs # runtime/devnet/src/extensions.rs # runtime/devnet/src/lib.rs # runtime/testnet/Cargo.toml # runtime/testnet/src/config/assets.rs
Required due to failure or coverage CI job.
Required due to failure or coverage CI job.
Co-authored-by: Tin Chung <56880684+chungquantin@users.noreply.github.com> Co-authored-by: Frank Bell <60948618+evilrobot-01@users.noreply.github.com>
evilrobot-01
requested changes
Sep 9, 2024
peterwht
reviewed
Sep 11, 2024
This was referenced Sep 11, 2024
Closed
Co-authored-by: Frank Bell <frank@r0gue.io>
Co-authored-by: Frank Bell <frank@r0gue.io> Co-authored-by: Frank Bell <60948618+evilrobot-01@users.noreply.github.com> Co-authored-by: Peter White <petras9789@gmail.com>
Co-authored-by: Frank Bell <frank@r0gue.io> Co-authored-by: Frank Bell <60948618+evilrobot-01@users.noreply.github.com>
Co-authored-by: Daanvdplas <daanvdplas@live.nl> Co-authored-by: Peter White <petras9789@gmail.com>
Co-authored-by: Daanvdplas <daanvdplas@live.nl> Co-authored-by: Frank Bell <frank@r0gue.io> Co-authored-by: Frank Bell <60948618+evilrobot-01@users.noreply.github.com> Co-authored-by: Peter White <petras9789@gmail.com>
Co-authored-by: Daanvdplas <daanvdplas@live.nl>
peterwht
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pop API + local fungibles implementation (minus native token)
Closes #65
Size of contract
pop-api/examples/fungibles/compared to the psp22 extension in ink-examples:Original wasm size: 31.3K, Optimized: 7.4K (current IT contract is bigger because there are more functions implemented)
Original wasm size: 30.3K, Optimized: 7.0K
Contains:
pop-api/examplestopop-api/integration-tests/contracts/#95transfer_fromanddecrease_allowance#104Merged after
optionally: