Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zombienet config #1

Closed
wants to merge 3 commits into from
Closed

Conversation

evilrobot-01
Copy link
Collaborator

@evilrobot-01 evilrobot-01 commented Feb 15, 2024

Adds zombienet config and simple readme using pop cli.

Tasks:

  • add chain once runtimes defined - e.g. devnet

NOTE: should only be merged once defaul branch updated with initial version.

@peterwht
Copy link
Collaborator

peterwht commented Feb 19, 2024

Looks good. My only recommendations are

  • add a "chain" field under [parachain] as we will have a few runtimes.
  • [subjective] Change the pop collator name to something like: "pop-collator01" or "pop01"


[relaychain]
chain = "rococo-local"
default_command = "./polkadot"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default_command = "./polkadot"
default_command = "./bin/polkadot"

[relaychain]
chain = "rococo-local"
default_command = "./polkadot"
default_args = ["--insecure-validator-i-know-what-i-do"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flag is already added by zombienet and will result in an error when added twice.

Suggested change
default_args = ["--insecure-validator-i-know-what-i-do"]

peterwht pushed a commit that referenced this pull request Feb 23, 2024
* pin stable toolchain

* Set workspace dependencies (#2)
@peterwht peterwht closed this Feb 23, 2024
@peterwht peterwht deleted the frank/feat-zombienet-config branch February 23, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants