Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to 1.13.0 #194

Merged
merged 101 commits into from
Aug 17, 2024

Merge branch 'developer' into chungquantin/chore-polkadot-v1.13.0

975b611
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

chore: upgrade to 1.13.0 #194

Merge branch 'developer' into chungquantin/chore-polkadot-v1.13.0
975b611
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Aug 17, 2024 in 0s

clippy

7 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 7
Note 0
Help 0

Versions

  • rustc 1.80.1 (3f5fd8dd4 2024-08-06)
  • cargo 1.80.1 (376290515 2024-07-16)
  • clippy 0.1.80 (3f5fd8d 2024-08-06)

Annotations

Check warning on line 44 in node/src/cli.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> node/src/cli.rs:5:1
   |
5  | / pub enum Subcommand {
6  | |     /// Build a chain specification.
7  | |     BuildSpec(sc_cli::BuildSpecCmd),
...  |
19 | |     ImportBlocks(sc_cli::ImportBlocksCmd),
   | |     ------------------------------------- the second-largest variant contains at least 240 bytes
...  |
39 | |     Benchmark(frame_benchmarking_cli::BenchmarkCmd),
   | |     ----------------------------------------------- the largest variant contains at least 544 bytes
...  |
43 | |     Key(sc_cli::KeySubcommand),
44 | | }
   | |_^ the entire enum is at least 544 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
39 |     Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
   |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 182 in runtime/testnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this match could be replaced by its body itself

warning: this match could be replaced by its body itself
   --> runtime/testnet/src/extensions.rs:180:15
    |
180 |       let result = match key {
    |  __________________^
181 | |         _ => Vec::<u8>::default(),
182 | |     }
    | |_____^ help: consider using the match body instead: `Vec::<u8>::default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
    = note: `#[warn(clippy::match_single_binding)]` on by default

Check warning on line 182 in runtime/devnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this match could be replaced by its body itself

warning: this match could be replaced by its body itself
   --> runtime/devnet/src/extensions.rs:180:15
    |
180 |       let result = match key {
    |  __________________^
181 | |         _ => Vec::<u8>::default(),
182 | |     }
    | |_____^ help: consider using the match body instead: `Vec::<u8>::default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
    = note: `#[warn(clippy::match_single_binding)]` on by default

Check warning on line 32 in runtime/testnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

bound is defined in more than one place

warning: bound is defined in more than one place
  --> runtime/testnet/src/extensions.rs:32:10
   |
32 |     fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
   |             ^
33 |     where
34 |         E: Ext<T = T>,
   |         ^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
   = note: `#[warn(clippy::multiple_bound_locations)]` on by default

Check warning on line 32 in runtime/devnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

bound is defined in more than one place

warning: bound is defined in more than one place
  --> runtime/devnet/src/extensions.rs:32:10
   |
32 |     fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
   |             ^
33 |     where
34 |         E: Ext<T = T>,
   |         ^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
   = note: `#[warn(clippy::multiple_bound_locations)]` on by default

Check warning on line 8 in runtime/testnet/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `metadata-hash`

warning: unexpected `cfg` condition value: `metadata-hash`
 --> runtime/testnet/build.rs:8:32
  |
8 | #[cfg(all(feature = "std", not(feature = "metadata-hash")))]
  |                                ^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: expected values for `feature` are: `default`, `runtime-benchmarks`, `std`, and `try-runtime`
  = help: consider adding `metadata-hash` as a feature in `Cargo.toml`
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 1 in runtime/testnet/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `metadata-hash`

warning: unexpected `cfg` condition value: `metadata-hash`
 --> runtime/testnet/build.rs:1:28
  |
1 | #[cfg(all(feature = "std", feature = "metadata-hash"))]
  |                            ^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: expected values for `feature` are: `default`, `runtime-benchmarks`, `std`, and `try-runtime`
  = help: consider adding `metadata-hash` as a feature in `Cargo.toml`
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
  = note: `#[warn(unexpected_cfgs)]` on by default