Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add interfaces & error for psp22 #297

Merged
merged 22 commits into from
Sep 24, 2024

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Sep 18, 2024

Interfaces

  • PSP22
  • PSP22Mintable
  • PSP22Burnable
  • PSP22Metadata
  • Management

Error

  • Implementation
  • Test

@chungquantin chungquantin linked an issue Sep 18, 2024 that may be closed by this pull request
@chungquantin chungquantin changed the title feat: add interfaces for psp22 feat: add interfaces & errors for psp22 Sep 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.47%. Comparing base (b653091) to head (8fc8d07).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   52.22%   51.47%   -0.76%     
==========================================
  Files          47       48       +1     
  Lines        4823     4894      +71     
  Branches     4823     4894      +71     
==========================================
  Hits         2519     2519              
- Misses       2255     2326      +71     
  Partials       49       49              

see 6 files with indirect coverage changes

@chungquantin chungquantin changed the title feat: add interfaces & errors for psp22 feat: add interfaces & error for psp22 Sep 18, 2024
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a few things that need to be addressed. It would be good also to remove the changes in terms of the example contract. This can be added in a separate PR to this PR which adds the example contract. Hereby other reviewers have an easier time reviewing the rest.

Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some mini nitpicks.

pop-api/src/v0/fungibles/errors.rs Outdated Show resolved Hide resolved
pop-api/src/v0/fungibles/events.rs Show resolved Hide resolved
pop-api/src/v0/fungibles/errors.rs Outdated Show resolved Hide resolved
pop-api/src/v0/fungibles/mod.rs Outdated Show resolved Hide resolved
pop-api/src/v0/fungibles/mod.rs Outdated Show resolved Hide resolved
pop-api/src/v0/fungibles/mod.rs Outdated Show resolved Hide resolved
pop-api/src/v0/fungibles/traits.rs Outdated Show resolved Hide resolved
pop-api/src/v0/fungibles/traits.rs Outdated Show resolved Hide resolved
pop-api/src/v0/fungibles/traits.rs Outdated Show resolved Hide resolved
pop-api/src/v0/fungibles/traits.rs Show resolved Hide resolved
pop-api/src/v0/fungibles/traits.rs Outdated Show resolved Hide resolved
pop-api/src/v0/fungibles/errors.rs Show resolved Hide resolved
pop-api/src/v0/fungibles/errors.rs Outdated Show resolved Hide resolved
@chungquantin chungquantin merged commit 5021c2f into main Sep 24, 2024
12 checks passed
@chungquantin chungquantin deleted the chungquantin/feat-psp22_traits branch September 24, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: psp22 traits
4 participants