-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add interfaces & error for psp22 #297
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #297 +/- ##
==========================================
- Coverage 52.22% 51.47% -0.76%
==========================================
Files 47 48 +1
Lines 4823 4894 +71
Branches 4823 4894 +71
==========================================
Hits 2519 2519
- Misses 2255 2326 +71
Partials 49 49 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, a few things that need to be addressed. It would be good also to remove the changes in terms of the example contract. This can be added in a separate PR to this PR which adds the example contract. Hereby other reviewers have an easier time reviewing the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some mini nitpicks.
Interfaces
Error