Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: token name & symbol return Option #312

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

Daanvdplas
Copy link
Collaborator

The psp22 standard returns an Option<String>. In stead of having the contract needing to add additional logic, we handle it in the pallet.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.50%. Comparing base (5021c2f) to head (9b1d98c).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   51.47%   51.50%   +0.02%     
==========================================
  Files          48       48              
  Lines        4894     4897       +3     
  Branches     4894     4897       +3     
==========================================
+ Hits         2519     2522       +3     
  Misses       2326     2326              
  Partials       49       49              
Files with missing lines Coverage Δ
pallets/api/src/fungibles/mod.rs 92.97% <100.00%> (+0.07%) ⬆️
pallets/api/src/fungibles/tests.rs 99.69% <100.00%> (+<0.01%) ⬆️

Copy link
Collaborator

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpitcks but not very important.

pallets/api/src/fungibles/tests.rs Outdated Show resolved Hide resolved
pallets/api/src/fungibles/tests.rs Outdated Show resolved Hide resolved
pop-api/integration-tests/src/fungibles/mod.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, made some minor suggestions for improving the tests which are quick and easy to implement if you so choose.

pallets/api/src/fungibles/tests.rs Outdated Show resolved Hide resolved
pallets/api/src/fungibles/tests.rs Outdated Show resolved Hide resolved
pallets/api/src/fungibles/tests.rs Outdated Show resolved Hide resolved
@Daanvdplas Daanvdplas merged commit 455a451 into main Oct 2, 2024
12 checks passed
@Daanvdplas Daanvdplas deleted the daan/feat-name_symbol_option branch October 2, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants