Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): api-integration-tests #317

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin self-assigned this Oct 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.47%. Comparing base (5021c2f) to head (b819f09).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   51.47%   51.47%           
=======================================
  Files          48       48           
  Lines        4894     4894           
  Branches     4894     4894           
=======================================
  Hits         2519     2519           
  Misses       2326     2326           
  Partials       49       49           

Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a TODO above

Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, would be better with a comment so that someone might try to remove it in the future rather than leaving it as is forever.

@evilrobot-01 evilrobot-01 merged commit 5083a46 into main Oct 2, 2024
11 checks passed
@evilrobot-01 evilrobot-01 deleted the chungquantin/fix-api_integration_tests branch October 2, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants