-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: pop-api v0 fungibles READMEs #365
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #365 +/- ##
=======================================
Coverage 54.34% 54.34%
=======================================
Files 49 49
Lines 5025 5025
Branches 5025 5025
=======================================
Hits 2731 2731
Misses 2245 2245
Partials 49 49 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one small detail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left some minor grammar adjustments, and proposal for renaming incentives.
Co-authored-by: Peter White <petras9789@gmail.com>
Co-authored-by: Peter White <petras9789@gmail.com>
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com> Co-authored-by: Peter White <petras9789@gmail.com>
Updates the existing pop-api README to use fungibles as example as well as expand some content.
It also includes two new documents presenting the v0 and the fungibles API.