Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: pop-api v0 fungibles READMEs #365

Merged
merged 12 commits into from
Nov 5, 2024
Merged

docs: pop-api v0 fungibles READMEs #365

merged 12 commits into from
Nov 5, 2024

Conversation

al3mart
Copy link
Collaborator

@al3mart al3mart commented Oct 31, 2024

Updates the existing pop-api README to use fungibles as example as well as expand some content.
It also includes two new documents presenting the v0 and the fungibles API.

pop-api/src/v0/README.md Outdated Show resolved Hide resolved
pop-api/README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.34%. Comparing base (f801a70) to head (a028e3f).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   54.34%   54.34%           
=======================================
  Files          49       49           
  Lines        5025     5025           
  Branches     5025     5025           
=======================================
  Hits         2731     2731           
  Misses       2245     2245           
  Partials       49       49           

@al3mart al3mart marked this pull request as ready for review November 1, 2024 14:47
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one small detail

pop-api/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some minor grammar adjustments, and proposal for renaming incentives.

pop-api/README.md Show resolved Hide resolved
pop-api/README.md Outdated Show resolved Hide resolved
pop-api/README.md Outdated Show resolved Hide resolved
al3mart and others added 2 commits November 1, 2024 17:39
Co-authored-by: Peter White <petras9789@gmail.com>
Co-authored-by: Peter White <petras9789@gmail.com>
@al3mart al3mart merged commit d642b42 into main Nov 5, 2024
5 checks passed
@al3mart al3mart deleted the al3mart/docs-api-readme branch November 5, 2024 20:40
chungquantin pushed a commit that referenced this pull request Nov 12, 2024
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
Co-authored-by: Peter White <petras9789@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants