feat: add pallet-contracts #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilrobot-01
force-pushed
the
peterwht/feat-add-pallet-contracts
branch
from
6294570
to
a2e77bd
Compare
Also decreases visibility of BalancesCall import.
evilrobot-01
approved these changes
Feb 24, 2024
| type CallFilter = AllowBalancesCall; | ||
| type DepositPerItem = DepositPerItem; | ||
| type DepositPerByte = DepositPerByte; | ||
| type CallStack = [pallet_contracts::Frame<Self>; 23]; |
There was a problem hiding this comment.
Note: probably doesnt matter for now, but Trappist has this configured as 5: https://github.com/paritytech/trappist/blob/a07b7e84224c53d16dbd1d5e3fb8797f33d12723/runtime/trappist/src/contracts.rs#L58
| pub const DepositPerByte: Balance = deposit(0, 1); | ||
| pub Schedule: pallet_contracts::Schedule<Runtime> = schedule::<Runtime>(); | ||
| pub const DefaultDepositLimit: Balance = deposit(1024, 1024 * 1024); | ||
| pub const CodeHashLockupDepositPercent: Perbill = Perbill::from_percent(0); |
There was a problem hiding this comment.
Note: probably doesnt matter for now, but Trappist has this configured as 30%: https://github.com/paritytech/trappist/blob/a07b7e84224c53d16dbd1d5e3fb8797f33d12723/runtime/trappist/src/contracts.rs#L38
Daanvdplas
added a commit
that referenced
this pull request
Jun 20, 2024
# This is the 1st commit message: refactor: general # This is the commit message #2: init # This is the commit message #3: begin refactor # This is the commit message #4: refactor: error handling # This is the commit message #5: tests: add error handling tests # This is the commit message #6: WIP # This is the commit message #7: finalise error handling # This is the commit message #8: refactor: easier review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.