Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add pop api documentation #74

Merged
merged 5 commits into from
May 5, 2024
Merged

Conversation

brunopgalvao
Copy link
Collaborator

@brunopgalvao brunopgalvao commented Apr 12, 2024

ditto

Please be hard on the feedback so we can make this perfect.

@brunopgalvao brunopgalvao changed the title feat: add Pop API documentation docs: add Pop API documentation Apr 12, 2024
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

pop-api/README.md Outdated Show resolved Hide resolved
pop-api/README.md Show resolved Hide resolved
@evilrobot-01 evilrobot-01 changed the title docs: add Pop API documentation docs: add pop api documentation Apr 14, 2024
@evilrobot-01
Copy link
Collaborator

Sadly I think we should wait until we downgrade pop-api to ink! v4 before we can merge this.

@brunopgalvao
Copy link
Collaborator Author

Sadly I think we should wait until we downgrade pop-api to ink! v4 before we can merge this.

Bumping the PR. Now that we will not be downgrading to inkv4 I believe we can merge this.

pop-api/README.md Outdated Show resolved Hide resolved
pop-api/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I suggest you add this text (Maybe without the links to the code) in our Documentation page too: https://learn.onpop.io/pop/welcome/pop-api

@Daanvdplas Daanvdplas merged commit 33505ba into main May 5, 2024
6 checks passed
@Daanvdplas Daanvdplas deleted the bruno/add-pop-api-README branch May 5, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants