build(deps): allow specifying ink version via feature #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilrobot-01
requested review from
brunopgalvao,
al3mart,
peterwht and
Daanvdplas
brunopgalvao
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Should the version of ink! be abstracted away by the API? For example, if you are using v1.x.x of the Pop API, it is using ink4 under-the-hood, whereas v2.x.x uses ink5. Especially because we will be versioning the Pop API. So:
pop-api = { path = "../../../pop-api", default-features = false, version = "1.0.0" }
|
Closing in favour of #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the selection of major ink version explicit until ink! v5 is audited. Not the best solution by any means, as it means that use needs to explicitly set the required version, but perhaps this at least allows the user to consider which version they are using. Perhaps also allows some backwards compatibility for now, but need to consider how this might work in the future when v5 becomes the default.
pop-api = { path = "../../../pop-api", default-features = false, features = ["inkv4"] }Example contracts alternate between using v4 and v5.
Closes #56