3.2.2+ update #60
Merged
3.2.2+ update #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikhilNarayana
force-pushed
the
task/update
branch
from
84bded8 to
0e557cf
Compare
NikhilNarayana
force-pushed
the
task/update
branch
from
0e557cf to
1aae4b7
Compare
NikhilNarayana
force-pushed
the
task/update
branch
2 times, most recently
from
1c3df56 to
2964a86
Compare
NikhilNarayana
force-pushed
the
task/update
branch
from
bb734bd to
b8284ff
Compare
TODO
investigation points
In ProgressDONE
|
NikhilNarayana
force-pushed
the
task/update
branch
3 times, most recently
from
dd125f1 to
14c0f9c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
NikhilNarayana
force-pushed
the
task/update
branch
from
9becba4 to
252fd28
Compare
NikhilNarayana
force-pushed
the
task/update
branch
from
22eb441 to
e09fca3
Compare
This second stack leads to JNI problems on Android, because ART fetches the address and size of the original stack using pthread functions (see GetThreadStack in art/runtime/thread.cc), and (presumably) treats stack addresses outside of the original stack as invalid. (What I don't understand is why some JNI operations on the CPU thread work fine despite this but others don't.) Instead of creating a second stack, let's borrow the approach ART uses: Use pthread functions to find out the stack's address and size, then install guard pages at an appropriate location. This lets us get rid of a workaround we had in the MsgAlert function. Because we're no longer choosing the stack size ourselves, I've made some tweaks to where the put the guard pages. Previously we had a stack of 2 MiB and a safe zone of 512 KiB. We now accept stacks as small as 512 KiB (used on macOS) and use a safe zone of 256 KiB. I feel like this should be fine, but haven't done much testing beyond "it seems to work". By the way, on Windows it was already the case that we didn't create a second stack... But there was a bug in the implementation! The code for protecting the stack has to run on the CPU thread, since it's the CPU thread's stack we want to protect, but it was actually running on EmuThread. This commit fixes that, since now this bug matters on other operating systems too.
Deduplication between Jit64 and JitArm64.
Android: Rewrite User Data Activity in Kotlin
Android: Initialize TaskViewModel earlier in User Data Activity
…ic to use custom texture data
* Move #endif to proper location on UICommon.cpp preventing compilation because of syntax error * Add missing include for unordered map and missing CodeTo implementation from Ishiiruka + Adjust code to use string_view * Trick compiler to think var is being used on Semver200_parser.cpp to prevent compilation errors on macos
add desync recovery bits and some other clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.