Migrated hardcoded strings to strings.dart #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ashwinkey04 is it proper? |
Yes it looks good. I will give it one last sanity check by building it locally and then will merge the PR. Thanks for contributing :) |
|
Okay @ashwinkey04 ! |
|
There are some duplicate imports of the file
|
|
sure @ashwinkey04 |
|
Done @ashwinkey04 |
|
The changes to strings.dart seems to have been lost. Could you re-check the commit? |
|
@ashwinkey04 apologies for that please check now made a new commit |
ashwinkey04
reviewed
Oct 28, 2021
| @@ -1,8 +1,8 @@ | |||
| import 'package:flutter/material.dart'; | |||
| import 'package:flutter/widgets.dart'; | |||
| import 'package:raag/model/strings.dart'; | |||
There was a problem hiding this comment.
This seems to be a duplicate import
lib/view/download_music.dart
Outdated
| @@ -233,7 +232,7 @@ class _DownloadMusicState extends State<DownloadMusic> { | |||
| leading: IconButton( | |||
| icon: Icon(Icons.arrow_back_ios_outlined), | |||
| onPressed: () => Navigator.pop(context)), | |||
| title: Text("Download music", | |||
| title: Text(downlaodMusic, | |||
There was a problem hiding this comment.
Could you also fix this typo
|
done @ashwinkey04 |
Awesome, merging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35