Add a CloseDeadline function to Connection #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did not set a milestone because, following strict-semver, a new public API function must be introduced in a new minor version :-/ |
|
@Zerpet I renamed |
A deadline to set an I/O timeout to Connection closure is important, because RabbitMQ may block the connection (during a memory alarm), and stop reading from the connection socket. In this case, Connection.Close() will block on I/O. Whilst closing the connection is not the solution to the memory alarm, an application should have the ability to close a connection to a service, regardless of the state of the service. Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
|
@Zerpet let me know if my recent changes are fine. |
lukebakken
approved these changes
Mar 10, 2023
|
Yeah, those changes look good 👍 I'm gladly surprised the new test works on GitHub Actions, I thought we didn't have access to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #178
Background information
During a memory alarm, RabbitMQ will block publisher connections. This means that RabbitMQ will stop reading from the connection socket. In this case, any further attempts from the client using this connection will be blocked on I/O. For example, a connection close request, will block in I/O, and the client application will be blocked.
Other clients, like Java or C#, use a timeout when closing a connection, and return an exception if the connection is not closed within the timeout. Those clients also do connection recovery, but that's outside of the scope of this client (See README anti-goals).
This client now also provides a
Connection.CloseDeadlinefunction to specify an I/O timeout for the connection close request to complete.