Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update write.go #221

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Update write.go #221

merged 1 commit into from
Sep 24, 2023

Conversation

pinkfish
Copy link
Contributor

Change the time comparison to use Equal, which is safer with timestamps in go.

@lukebakken lukebakken self-assigned this Sep 24, 2023
@lukebakken lukebakken added this to the 1.9.0 milestone Sep 24, 2023
@pinkfish @lukebakken
Update write.go
4a77835 
Change the time comparison to use Equal, which is safer with timestamps in go.

Use IsZero()
@lukebakken lukebakken requested a review from Zerpet September 24, 2023 14:21
lukebakken
lukebakken approved these changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@michaelklishin michaelklishin merged commit 831d90b into rabbitmq:main Sep 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebakken lukebakken lukebakken approved these changes

@michaelklishin michaelklishin michaelklishin approved these changes

@Zerpet Zerpet Awaiting requested review from Zerpet

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pinkfish @michaelklishin @lukebakken