Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

khepri_bang: unwrapped_minimnal_ret() can be ok only #311

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

dumbbell
Copy link
Member

Why

It can't have an error, that's the point of the bang functions.

[Why]
It can't have an error, that's the point of the bang functions.
@dumbbell dumbbell added the bug Something isn't working label Dec 12, 2024
@dumbbell dumbbell added this to the v0.17.0 milestone Dec 12, 2024
@dumbbell dumbbell self-assigned this Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.70%. Comparing base (39a97d7) to head (b1702bb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   89.73%   89.70%   -0.04%     
==========================================
  Files          22       22              
  Lines        3263     3263              
==========================================
- Hits         2928     2927       -1     
- Misses        335      336       +1     
Flag Coverage Δ
erlang-25 88.96% <ø> (-0.04%) ⬇️
erlang-26 89.36% <ø> (+0.12%) ⬆️
erlang-27 89.33% <ø> (+0.06%) ⬆️
os-ubuntu-latest 89.70% <ø> (+0.03%) ⬆️
os-windows-latest 89.42% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dumbbell dumbbell marked this pull request as ready for review December 12, 2024 16:29
@dumbbell dumbbell merged commit 1c29b1d into main Dec 12, 2024
26 checks passed
@dumbbell dumbbell deleted the fix-bang-function-minimal-ret-typespec branch December 12, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant