ra_machine: Allow the version/0 callback to return 0
#399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
improve-version-callback-spec
branch
2 times, most recently
from
656a5ee to
1c9155e
Compare
dumbbell
changed the title
version/0 callback return a version() typeversion/0 callback to return 0
[Why] 0 is now a valid value the `version/0` callback can return. It has always been a valid value, but the callback couldn't return that. This allows a Ra machine module to explicitly set the initial version, even though it is the default implicit one. [How] The `assert_integer/1` function, renamed to `assert_version/1` in the progress, now accepts 0 as a valid value. The `version/0` callback spec is improved to return the `version()` type. The `is_versioned/1` helper behavior changes: an unversioned Ra machine is a module which doesn't export the `version/0` callback.
the-mikedavis
force-pushed
the
improve-version-callback-spec
branch
from
1c9155e to
72a69a4
Compare
kjnilsson
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
0 is now a valid value the
version/0callback can return. It has always been a valid value, but the callback couldn't return that.This allows a Ra machine module to explicitly set the initial version, even though it is the default implicit one.
How
The
assert_integer/1function, renamed toassert_version/1in the progress, now accepts 0 as a valid value.The
version/0callback spec is improved to return theversion()type.The
is_versioned/1helper behavior changes: an unversioned Ra machine is a module which doesn't export theversion/0callback.