-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure OIDC end_session_endpoint #11218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcialRosales
force-pushed
the
configure-oidc-endpoints
branch
3 times, most recently
from
May 22, 2024 12:45
09be5b4
to
86730b7
Compare
MarcialRosales
force-pushed
the
configure-oidc-endpoints
branch
from
May 22, 2024 15:03
065cb62
to
9fef822
Compare
MarcialRosales
changed the title
Configure all required OIDC endpoints
Configure end_session_endpoint OIDC endpoints
May 23, 2024
MarcialRosales
requested review from
pstack2021 and
michaelklishin
and removed request for
pstack2021
May 23, 2024 10:03
MarcialRosales
force-pushed
the
configure-oidc-endpoints
branch
from
May 23, 2024 10:25
ad023f6
to
4c98e21
Compare
MarcialRosales
changed the title
Configure end_session_endpoint OIDC endpoints
Configure OIDC end_session_endpoint
May 23, 2024
michaelklishin
requested changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Dialyzer failure looks legit
Proceeding with analysis...
oauth2_client.erl:22:29: The call oauth2_client:get_oauth_provider
(OAuth2ProviderId :: binary(),
['token_endpoint']) will never return since the success typing is
([any()],
any()) ->
{'error', _} |
{'ok',
#oauth_provider{issuer ::
'none' | 'undefined' |
binary() |
maybe_improper_list(binary() |
maybe_improper_list(any(),
binary() |
[]) |
byte(),
binary() | []),
token_endpoint ::
'none' | 'undefined' |
binary() |
maybe_improper_list(binary() |
maybe_improper_list(any(),
binary() |
[]) |
byte(),
binary() | []),
authorization_endpoint ::
'none' | 'undefined' |
binary() |
maybe_improper_list(binary() |
maybe_improper_list(any(),
binary() |
[]) |
byte(),
binary() | []),
end_session_endpoint ::
'none' | 'undefined' |
binary() |
maybe_improper_list(binary() |
maybe_improper_list(any(),
binary() |
[]) |
byte(),
binary() | []),
jwks_uri ::
'none' | 'undefined' |
binary() |
maybe_improper_list(binary() |
maybe_improper_list(any(),
binary() |
[]) |
byte(),
binary() | []),
ssl_options :: 'undefined' | [any()]}} and the contract is
([any()], boolean()) ->
{'ok', oauth_provider()} | {'error', any()}
done in 0m0.53s
done (warnings were emitted)
oauth2_client:get_oauth_provider/2
expects a list according to its type spec and oauth2_client.erl:22
calls it with a single value as far as I can tell.
MarcialRosales
force-pushed
the
configure-oidc-endpoints
branch
3 times, most recently
from
May 24, 2024 14:44
33a0671
to
2d7397f
Compare
MarcialRosales
force-pushed
the
configure-oidc-endpoints
branch
from
May 27, 2024 09:19
2d7397f
to
72ab194
Compare
michaelklishin
approved these changes
Jun 3, 2024
12 tasks
michaelklishin
added a commit
that referenced
this pull request
Jun 3, 2024
michaelklishin
added a commit
that referenced
this pull request
Jun 3, 2024
Configure OIDC end_session_endpoint (backport #11218)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implements feature request #11103
Doc's PR -> rabbitmq/rabbitmq-website#1925
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.