Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically load oauth-related libraries #11448

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Jun 13, 2024

Proposed Changes

It addresses one issue raised and two more issues found but not raised:

  • Load oauth javascript dependencies only when they are required #11421
  • the logged in user's name should only be a hyperlink to the user's record when the user is an administrator and it has been authenticated with the internal backend. In other words, if the user was authenticated with oauth or ldap or http, there is no internal record of the user hence the username should not be rendered as a hyperlink.
  • disable browser login dialog-box and instead always redirect the user to the login html page when either the credentials are wrong or user is not authorized or session has expired

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@MarcialRosales MarcialRosales force-pushed the dynamic-load-oauth-deps-ui branch 6 times, most recently from f762e8a to f053fd2 Compare June 18, 2024 10:47
@MarcialRosales MarcialRosales self-assigned this Jun 18, 2024
@MarcialRosales MarcialRosales force-pushed the dynamic-load-oauth-deps-ui branch 4 times, most recently from 6f846f1 to 26489f6 Compare June 20, 2024 08:04
@MarcialRosales MarcialRosales marked this pull request as ready for review June 20, 2024 09:38
@michaelklishin michaelklishin force-pushed the dynamic-load-oauth-deps-ui branch from 20c39e8 to f0adf3a Compare June 20, 2024 16:42
@michaelklishin
Copy link
Member

The forced push was a rebase.

@michaelklishin michaelklishin merged commit c67c940 into main Jun 21, 2024
251 checks passed
@michaelklishin michaelklishin deleted the dynamic-load-oauth-deps-ui branch June 21, 2024 01:37
michaelklishin added a commit that referenced this pull request Jun 21, 2024
michaelklishin added a commit that referenced this pull request Jun 21, 2024
Dynamically load oauth-related libraries  (backport #11448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants