Close stream connection with delay in case of authentication failure #11831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with other protocols (to protect from potential DoS attacks). Wrong credentials and virtual host access errors trigger the delay.
michaelklishin
approved these changes
Jul 25, 2024
michaelklishin
deleted the
stream-plugin-close-with-delay-on-authentication-failure
branch
michaelklishin
added a commit
that referenced
this pull request
Jul 25, 2024
Close stream connection with delay in case of authentication failure (backport #11831)
ansd
added a commit
that referenced
this pull request
Aug 5, 2024
For consistency with other protocols (to protect from potential DoS attacks). Wrong credentials and virtual host access errors trigger the delay. References #11831 We keep the delay low when running tests. Otherwise, ``` make -C deps/rabbitmq_mqtt ct-auth ``` would run 3 minutes longer (with a SILENT_CLOSE_DELAY of 3 seconds).
mergify bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
For consistency with other protocols (to protect from potential DoS attacks). Wrong credentials and virtual host access errors trigger the delay. References #11831 We keep the delay low when running tests. Otherwise, ``` make -C deps/rabbitmq_mqtt ct-auth ``` would run 3 minutes longer (with a SILENT_CLOSE_DELAY of 3 seconds). (cherry picked from commit 80ff6d0)
ansd
added a commit
that referenced
this pull request
Aug 5, 2024
For consistency with other protocols (to protect from potential DoS attacks). Wrong credentials and virtual host access errors trigger the delay. References #11831 We keep the delay low when running tests. Otherwise, ``` make -C deps/rabbitmq_mqtt ct-auth ``` would run 3 minutes longer (with a SILENT_CLOSE_DELAY of 3 seconds). (cherry picked from commit 80ff6d0)
mergify bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
For consistency with other protocols (to protect from potential DoS attacks). Wrong credentials and virtual host access errors trigger the delay. References #11831 We keep the delay low when running tests. Otherwise, ``` make -C deps/rabbitmq_mqtt ct-auth ``` would run 3 minutes longer (with a SILENT_CLOSE_DELAY of 3 seconds). (cherry picked from commit 80ff6d0) (cherry picked from commit 9e84378)
michaelklishin
pushed a commit
that referenced
this pull request
Aug 6, 2024
For consistency with other protocols (to protect from potential DoS attacks). Wrong credentials and virtual host access errors trigger the delay. References #11831 We keep the delay low when running tests. Otherwise, ``` make -C deps/rabbitmq_mqtt ct-auth ``` would run 3 minutes longer (with a SILENT_CLOSE_DELAY of 3 seconds). (cherry picked from commit 80ff6d0) (cherry picked from commit 9e84378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with other protocols (to protect from potential DoS attacks). Wrong credentials and virtual host access errors trigger the delay.