QQ: fix a bug with discards using a consumer_id() #12442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
gh_12424
branch
2 times, most recently
from
5ea9b6b to
e7a1201
Compare
Fixes a pattern matching bug for discards that come in after a consumer
has been cancelled. Because the rabbit_fifo_client does not keep
the integer consumer key after cancellation, late acks, returns, and
discards use the full {CTag, Pid} consumer id version.
As this is a state machine change the machine version has been
increased to 5.
The same bug is present for the `modify` command also however as
AMQP does not allow late settlements we don't have to make this
fix conditional on the machine version as it cannot happen.
michaelklishin
approved these changes
Oct 7, 2024
michaelklishin
changed the title
michaelklishin
added a commit
that referenced
this pull request
Oct 7, 2024
QQ: fix bug with discards using a consumer_id() (backport #12442)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a pattern matching bug for discards that come in after a consumer has been cancelled. Because the rabbit_fifo_client does not keep the integer consumer key after cancellation, late acks, returns, and discards use the full {CTag, Pid} consumer id version.
As this is a state machine change the machine version has been increased to 5.
The same bug is present for the
modifycommand also however as AMQP does not allow late settlements we don't have to make this fix conditional on the machine version as it cannot happen.Fixes: #12424