Return queue-prefix in open properties #12541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
force-pushed
the
open-properties-target-address-prefix
branch
from
222e87f to
45b9ad5
Compare
alaendle
reviewed
Oct 18, 2024
ansd
force-pushed
the
open-properties-target-address-prefix
branch
2 times, most recently
from
44d4714 to
cfccb78
Compare
ansd
changed the title
This commit notifies the client app with the AMQP performative if connection config `notify_with_performative` is set to `true`. This allows the client app to learn about all fields including properties and capabilities returned by the AMQP server.
The `queue-prefix` property of the `open` frame is not part of the AMQP spec. However, let's include this property because it is also returned by ActiveMQ and Solace and understood by some client libs, e.g. ActiveMQ NMS.AMQP and Qpid JMS. Note that we do not set `topic-prefix` here because `/exchanges/amq.topic/` is a valid target address prefix but not a valid source address prefix. Closes #12531
ansd
force-pushed
the
open-properties-target-address-prefix
branch
from
cfccb78 to
56bc881
Compare
fails with this PR because the JMS client starts using Also note that setting the We can re-evaluate whether RabbitMQ returning a queue-prefix The 1st commit of this PR got extracted into #12547 since it will help writing test cases for other features such as #12520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12531
See commit messages for more details.