CLI: Finish check_if_any_deprecated_features_are_used implementation
#12675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
fix-check_if_any_deprecated_features_are_used-cli-command
branch
from
0297ec9 to
16ca325
Compare
[Why] The previous implementation bypassed the deprecated features subsystem. It only cared about classic mirrored queues and called some queue-related code directly to determine if this specific feature was used. [How] The command code is simplified by calling the deprecated subsystem to list used deprecated features instead. References #12619.
dumbbell
force-pushed
the
fix-check_if_any_deprecated_features_are_used-cli-command
branch
from
16ca325 to
ddaea6f
Compare
michaelklishin
approved these changes
Nov 14, 2024
michaelklishin
deleted the
fix-check_if_any_deprecated_features_are_used-cli-command
branch
dumbbell
added a commit
that referenced
this pull request
Nov 15, 2024
CLI: Finish `check_if_any_deprecated_features_are_used` implementation (backport #12675)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The previous implementation bypassed the deprecated features subsystem. It only cared about classic mirrored queues and called some queue-related code directly to determine if this specific feature was used.
How
The command code is simplified by calling the deprecated subsystem to list used deprecated features instead.
References #12619.