Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.0.x: Avoid an exception when an AMQP 0-9-1-originating message with expiration set is converted for an MQTT consumer #12708

Closed
wants to merge 2 commits into from
Closed

4.0.x: Avoid an exception when an AMQP 0-9-1-originating message with expiration set is converted for an MQTT consumer #12708

wants to merge 2 commits into from

Conversation

michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented Nov 12, 2024 •
edited
Loading

Note: this is submitted directly against v4.0.x because the mc_mqtt module in main is different and an equivalent line must be located first, so there might be a separate future PR for that.

See #12707.

Version for main: #12710.

To reproduce the exception:

  1. Start a node with rabbitmq_mqtt enabled
  2. Tail its logs
  3. Install github.com/rabbitmq/omq
  4. omq amqp-mqtt --message-ttl 10s -t /topic/my_topic -T my_topic -C 1

@michaelklishin
MQTT: avoid an exception
d0b1aff 
when an AMQP 0-9-1 publisher publishes a message
that has expiration set.

Stack trace was contributed in #12707 by @rdsilio.
@michaelklishin michaelklishin added this to the 4.0.4 milestone Nov 12, 2024
@michaelklishin michaelklishin changed the title Avoid an exception when an AMQP 0-9-1-originating message with expiration set is converted for an MQTT consumer 4.0.x: Avoid an exception when an AMQP 0-9-1-originating message with expiration set is converted for an MQTT consumer Nov 12, 2024
@michaelklishin michaelklishin mentioned this pull request Nov 12, 2024
Merged
@mergify mergify bot mentioned this pull request Nov 13, 2024
Merged
@ansd
Copy link
Member

ansd commented Nov 13, 2024

Closed in favour of the Mergify backport in #12711

@ansd ansd closed this Nov 13, 2024
@michaelklishin michaelklishin deleted the mk-mc-mqtt-rabbitmq-server-discussion-12707 branch November 13, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelklishin @ansd