Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See #4980. Give *.absolute precedence over *.relative configuration #6535

Merged

Conversation

SimonUnge
Copy link
Member

@SimonUnge SimonUnge commented Nov 30, 2022

Proposed Changes

Closes #4980.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@michaelklishin michaelklishin added this to the 3.11.5 milestone Nov 30, 2022
@michaelklishin michaelklishin merged commit ee57f0f into rabbitmq:main Nov 30, 2022
michaelklishin added a commit that referenced this pull request Nov 30, 2022
See #4980. Give *.absolute precedence over *.relative configuration (backport #6535)
@michaelklishin
Copy link
Member

Note that the log message won't be visible in most environments but that's fine. This precedence order is what most people want. At least most people we see end up in this conflicting config settings situation.

michaelklishin added a commit that referenced this pull request Nov 30, 2022
See #4980. Give *.absolute precedence over *.relative configuration (backport #6535) (backport #6536)
@SimonUnge SimonUnge deleted the 4980-absolute_before_relative branch December 1, 2022 18:34
@michaelklishin michaelklishin removed this from the 3.11.5 milestone Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants