New event to handle Metadata update #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
event. The event is needed to handle multi producers and multi consumers per connection. Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 92.49% 92.92% +0.42%
==========================================
Files 113 115 +2
Lines 9946 10845 +899
Branches 825 878 +53
==========================================
+ Hits 9200 10078 +878
- Misses 567 574 +7
- Partials 179 193 +14 ☔ View full report in Codecov by Sentry. |
|
@jonnepmyra FYI |
Remove duplication code between the Raw* classes and moved to AbstractEntity class. Fix a rare condition where the producer still receive confirmation but the producer was removed from the internal list due of cancellation. Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Zerpet
previously approved these changes
Dec 15, 2023
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR #328 the client can handle multi-producers and consumers per connection.
This PR removes
MetadataHandlerand introducesOnMetadataUpdateevent.The event can handle multiple Metadata updates coming from the server. Metadata update is raised when a stream is deleted, or a replica is removed.
The server automatically removes the producers and consumers linked to the connection, here we need to remove these entities from the internal pool to be consistent.
How to test
RawProducerandRawConsumerbind to one or more streams. Delete the streams and the client has to remove all the connectionsProducerandConsumerin a cluster remove a replica theProducerandConsumershould reconnect and continue to workRefactor
Refactor
RawConsumerandRawProducerin this commit. Remove duplication code. Move the common code to theAbstractEntityClass