Improve Reconnection #343
Merged
Improve Reconnection #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Part of #336 * Improve the disconnection message. It is possible to understand if it is a normal disconnection or an unexpected. * Remove the Active Items from the connection pool and use the Publishers and Consumers client list directly to check the pool size * Refactor the Factory Classes. Remove code duplication in case of metadata update and connection closed. See ReliableBase.OnEntityClosed * Handle streamNotAvailable error. In this case the client will try to reconnect the entity * Fix the events attach to the RawConsumer and RawProducer. The events are attached only if the ResponseCode is OK * Detach the events once the entity receives the disconnection or metadata update. In that case, the entity is closed * Introduce ReliableEntityStatus like a state machine to understand the status of Producer and Consumer classes * Add ResourceAvailableReconnectStrategy interface to Handle the retry in case testing in a stream exists. See ReliableBase CheckIfStreamIsAvailable * Change the MetadataHandler to Func<MetaDataUpdate, Task> to be like the other methods * Producer and Consumer classes fail fast during the first initialization. The user is aware of what is happening. The reconnect part occurs only after the first boot. Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
* clean the publishers and consumers list when a connection is removed * restore pool tests * more clear logs Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
lukebakken
previously approved these changes
Jan 10, 2024
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
|
@lukebakken Thanks for the help! Lock removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Improve reconnection #336
Improve the disconnection message. It is possible to understand if it is a normal disconnection or an unexpected.
Remove the Active Items from the connection pool and use the Publishers and Consumers client list directly to check the pool size
Refactor the Factory Classes. Remove code duplication in case of metadata update and connection closed. See ReliableBase.OnEntityClosed
Handle streamNotAvailable error. In this case the client will try to reconnect the entity
Fix the events attach to the RawConsumer and RawProducer. The events are attached only if the ResponseCode is OK
Detach the events once the entity receives the disconnection or metadata update. In that case, the entity is closed
Introduce ReliableEntityStatus like a state machine to understand the status of Producer and Consumer classes
Add ResourceAvailableReconnectStrategy interface to Handle the retry in case testing in a stream exists. See ReliableBase CheckIfStreamIsAvailable
Change the MetadataHandler to Func<MetaDataUpdate, Task> to be like the other methods
Producer and Consumer classes fail fast during the first initialization. The user is aware of what is happening. The reconnect part occurs only after the first boot.
How to test
execute a script with multiple consumers and producers:
I use https://gist.github.com/Gsantomaggio/f6a091076e498d88ecfe827c2b165dad
restart the docker nodes and see if the client will survive to the restart