Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hunter rust stable #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

06kellyjac
Copy link

@06kellyjac 06kellyjac commented Oct 6, 2020

Resolves #89
Closes #91

  • Ported @bhavitsharma's changes without the big formatting overhaul.
  • Fixed an ownership issue with core.

image

For my fellow nix users, this is the shell.nix I was using:

let
  moz_overlay = import (builtins.fetchTarball https://github.com/mozilla/nixpkgs-mozilla/archive/master.tar.gz);
  nixpkgs = import <nixpkgs> { overlays = [ moz_overlay ]; };
  ruststable = (nixpkgs.latest.rustChannels.stable.rust.override { extensions = [ "rust-src" "rls-preview" "rust-analysis" "rustfmt-preview" ];});
in
  with nixpkgs;
  stdenv.mkDerivation {
    name = "rust";
    buildInputs = [ openssl pkgconfig nasm rustup ruststable cmake zlib glibc glib gst_all_1.gstreamer gst_all_1.gst-plugins-base.dev gst_all_1.gst-plugins-bad.dev ];
  }

I didn't really think things through, just grabbed an existing shell.nix I had to hand and kept slapping on dependencies until cargo/pkgconfig stopped complaining.

@teto @magnetophon
I wouldn't mind being added as a maintainer once either of you adds to nixpkgs 😉

06kellyjac and others added 2 commits October 7, 2020 00:53
This commit comprises changes made by @bhavidsharma in PR rabite0#91 without
the other formatting changes.
rabite0#91

It took quite a while to scroll through and pick out the important bits.

This commit wasn't written with Bhavit but I thought it important to
include them as a co-author as it was originally their changes.

Co-authored-by: Bhavit Sharma <bhavitsharma@google.com>
@magnetophon
Copy link

@06kellyjac Thanks!

I wouldn't mind being added as a maintainer once either of you adds to nixpkgs

If you wan't I'll gladdly add you here!

@teto
Copy link

teto commented Oct 9, 2020

I am no rust user so can't review but I hope to see hunter in nixpkgs so hoping you can fix the CI and get the PR merged kudos to you

@06kellyjac
Copy link
Author

06kellyjac commented Oct 9, 2020

I've given fixing CI a bit of a try ( #110 ) but it's broken on master too. https://github.com/rabite0/hunter/commits/master
It hasn't successfully ran since 2019-05-06 540eb82

@jedahan
Copy link

jedahan commented Dec 28, 2020

Just tested and packaged this fork since my distro doesn't support nightly rust (its musl based and is a bit more fragile than most). Compiles and runs well, thank you @06kellyjac

@06kellyjac
Copy link
Author

06kellyjac commented Dec 28, 2020

Np @jedahan

If you use nix package manager I've got it packaged in my NUR.

https://nur.nix-community.org/repos/j-k/

Theres a cache too so you dont need to compile it yourself if you check:
https://github.com/06kellyjac/nur-packages/


Edit: update I removed it from my nur as it was packaged in main nixpkgs but there is also talk of maybe removing it since the project is halted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packaging a version that doesn't need nightly
4 participants