-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hunter rust stable #109
base: master
Are you sure you want to change the base?
hunter rust stable #109
Conversation
226511b
to
2ffa81d
Compare
This commit comprises changes made by @bhavidsharma in PR rabite0#91 without the other formatting changes. rabite0#91 It took quite a while to scroll through and pick out the important bits. This commit wasn't written with Bhavit but I thought it important to include them as a co-author as it was originally their changes. Co-authored-by: Bhavit Sharma <bhavitsharma@google.com>
2ffa81d
to
2e95cc5
Compare
@06kellyjac Thanks!
If you wan't I'll gladdly add you here! |
I am no rust user so can't review but I hope to see hunter in nixpkgs so hoping you can fix the CI and get the PR merged kudos to you |
I've given fixing CI a bit of a try ( #110 ) but it's broken on master too. https://github.com/rabite0/hunter/commits/master |
Just tested and packaged this fork since my distro doesn't support nightly rust (its musl based and is a bit more fragile than most). Compiles and runs well, thank you @06kellyjac |
Np @jedahan If you use nix package manager I've got it packaged in my NUR. https://nur.nix-community.org/repos/j-k/ Theres a cache too so you dont need to compile it yourself if you check: Edit: update I removed it from my nur as it was packaged in main nixpkgs but there is also talk of maybe removing it since the project is halted |
Resolves #89
Closes #91
For my fellow nix users, this is the
shell.nix
I was using:I didn't really think things through, just grabbed an existing
shell.nix
I had to hand and kept slapping on dependencies untilcargo
/pkgconfig
stopped complaining.@teto @magnetophon
I wouldn't mind being added as a maintainer once either of you adds to nixpkgs 😉