Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

order of class and cwlVersion inconsitent with bio-cwl-tools recommendations #15

Closed
pvanheus opened this issue Dec 30, 2020 · 0 comments
Closed

order of class and cwlVersion inconsitent with bio-cwl-tools recommendations #15

pvanheus opened this issue Dec 30, 2020 · 0 comments

Comments

@pvanheus
Copy link
Contributor

The contribution guide for bio-cwl-tools states that tools should start with:

#!/usr/bin/env cwl-runner
cwlVersion: v1.0
class: CommandLineTool

The order done by cwl-format puts class first. While neither cwl-format nor bio-cwl-tools are formal standards, I'd suggest that cwl-format be changed to put cwlVersion first.

Peter
pvanheus added a commit to pvanheus/cwl-format that referenced this issue Dec 31, 2020
@pvanheus
Swap order of cwlVersion and class
e989010 
As per rabix#15, swap order of cwlVersion and class to make `cwl-format` consistent with recommended best practice.
@pvanheus pvanheus mentioned this issue Dec 31, 2020
Merged
@ghost ghost closed this as completed in 752b3cb Jan 5, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pvanheus