[WIP] ecommerce Basket Page -> micro-frontend #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarov
requested changes
May 5, 2022
ecommerce/core/models.py
Outdated
| @@ -376,6 +370,7 @@ def enterprise_grant_data_sharing_url(self): | |||
|
|
|||
| @property | |||
| def payment_domain_name(self): | |||
| # TODO: update it | |||
There was a problem hiding this comment.
It seems it is a time for updating, since self argument is removed
ecommerce/tests/factories.py
Outdated
| @@ -41,6 +41,7 @@ class Meta: | |||
| enable_embargo_check = False | |||
| enable_partial_program = False | |||
| discovery_api_url = 'http://{}.fake/'.format(Faker().domain_name()) | |||
| payment_microfrontend_url = 'http://{}.fake/'.format(Faker().domain_name()) | |||
There was a problem hiding this comment.
nit: I would use f-string instead of format?
dyudyunov
reviewed
May 11, 2022
dyudyunov
approved these changes
May 11, 2022
ruzniaievdm
approved these changes
May 12, 2022
UvgenGen
force-pushed
the
depr/basket_page
branch
from
8633e7a to
af8daa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openedx/public-engineering#68
OeX_Depr-158 ecommerce Basket Page -> micro-frontend