Introduce a Redis proxy compatible with ~>redis-3.0. #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm just debugging issues with non expiring keys in Rails 5.2 and built in Redis cache wrapper, and with this PR I found a working workaround. |
|
BTW, looks like a duplicate of #280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #213, #136, #190.
Root cause analysis is contained in #213.
In this new
RedisProxywe just throw away theredis-storeextensions to the plainredisinterface. We have been using a similar approach in production for almost a year without issues. That being said, we only use the rate-throttling (and not the fail2ban) behaviour of rack-attack.Let me know if you require further information or would like to make any amendments to the pull request.