return 400 bad request when contradiction between body and type #134
Conversation
|
Thanks for the PR. I don't think you have to worry too much about #76 superseding this one; it doesn't look like anyone's going to be cleaning that up for merge any time soon. I'm fine with the intent of your change, but I think your framing of the problem in the tests (thanks for providing them) could be improved. To me, the core of the issue is that the provided content doesn't conform to the rules required of the specified Content-Type. Also, I'm not a fan of putting exception classes in error messages, because they don't mean anything to someone who isn't a Ruby programmer (the heathens!); it would be better to describe the error as something like "failed to parse body as JSON". If you could tweak the change to incorporate those changes, I'll merge. |
|
@mpalmer Thank you for your review 😃 I've updated response message. |
| @@ -34,11 +34,11 @@ | |||
| end | |||
|
|
|||
| describe "contradiction between body and type" do | |||
| def assert_bad_request(response, err_class) | |||
| def assert_failed_to_parse_as_json(response, err_class) | |||
There was a problem hiding this comment.
So, err_class is no longer actually used in the assertion... can probably take that out.
There was a problem hiding this comment.
Oh, I had overlooked it 😓 I removed it and pushed.
|
Teeny tiny little nit picked... |
|
OK, I've merged this in. It'll be in the next release, slated for the first of next month. Thanks for your contribution! |
PostBodyContentTypeParser will stop at 500 error if body and content-type are inconsistent.
e.g. POST as
content-type=application/jsonbut passed bodyfoobar.With this pull request, set the response to 400 and tell the client that the cause of the error is in the request.