Fix the bug that TryStatic returns 405 "Method Not Allowed" Error #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guss77
added a commit
that referenced
this pull request
Oct 31, 2014
Fix the bug that TryStatic returns 405 "Method Not Allowed" Error (Sorry for jumping - I said I'll wait with the pull requests, but I decided I really want this.)
|
@guss77 this PR has no tests, it should not have been merged IMO |
|
You are correct. I've been using this patch on my system for a while so I considered it safe. Would you prefer if I revert and merge after there are tests added? |
|
@guss77, it'd probably be easier just to add a couple of tests... |
|
@guss77 yeah just add the tests in another PR |
|
@guss77 would be great to see that test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #85