Fixes #64 - Removes new line from basic auth

History.md

@@ -26,6 +26,7 @@
     #125)
   * Update README code example quotes to be consistent. (Dmitry Gritsay #112)
   * Update README not to recommend installing gem with sudo. (T.J. Schuck #87)
+  * Removed new line from basic auth. (Felix Kleinschmidt #185)
 
 ## 0.6.3 / 2015-01-09
 

lib/rack/test.rb

@@ -160,7 +160,7 @@ def env(name, value)
       # Example:
       #   basic_authorize "bryan", "secret"
       def basic_authorize(username, password)
-        encoded_login = ["#{username}:#{password}"].pack("m*")
+        encoded_login = ["#{username}:#{password}"].pack("m0")
         header('Authorization', "Basic #{encoded_login}")
       end
 

spec/rack/test_spec.rb

@@ -339,20 +339,20 @@ def close
     end
   end
 
-  describe "#authorize" do
+  describe "#basic_authorize" do
     it "sets the HTTP_AUTHORIZATION header" do
       authorize "bryan", "secret"
       request "/"
 
-      expect(last_request.env["HTTP_AUTHORIZATION"]).to eq("Basic YnJ5YW46c2VjcmV0\n")
+      expect(last_request.env["HTTP_AUTHORIZATION"]).to eq("Basic YnJ5YW46c2VjcmV0")
     end
 
     it "includes the header for subsequent requests" do
       basic_authorize "bryan", "secret"
       request "/"
       request "/"
 
-      expect(last_request.env["HTTP_AUTHORIZATION"]).to eq("Basic YnJ5YW46c2VjcmV0\n")
+      expect(last_request.env["HTTP_AUTHORIZATION"]).to eq("Basic YnJ5YW46c2VjcmV0")
     end
   end