Header Capitalization and Underscorizing

[erithmetic]

Bryan,

First thanks for all you awesome work on Rack::Test!

We are using Rack::Test to test the interplay of several rack apps. We've been using some custom headers, similar to X-Custom-Header. Our code expects that the request env should contain env['HTTP_X_CUSTOM_HEADER']. Looking through Rack::Test, we saw that headers are not renamed when Rack::Test::Session#header('X-Custom-Header','value') was used.

Is this intentional?

According to Google, all web servers send headers in this uppercase, underscorized form to CGI apps. Is this something Rack::Test should emulate or should we roll our own solution?

Thanks!

-Derek

[erithmetic]

Also, according to http://rack.rubyforge.org/doc/files/SPEC.html, Rack expects the environment to have all headers translated to HTTP_* format.

[brynary]

Hey Derek,

Thanks for the report. Sorry it took awhile to get to this -- Wasn't looking here for bug reports.

I believe you are correct about the behavior. Just pushed a fix to master, which will go into a 0.5 release.

Cheers,

-Bryan