Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to rspec 3 #134

Closed
wants to merge 1 commit into from
Closed

Port to rspec 3 #134

wants to merge 1 commit into from

Conversation

terceiro
Copy link

Used transpec and a did a few manual tweaks

Used transpec and a did a few manual tweaks
@junaruga
Copy link
Contributor

Hello @brynary
I want you to merge this pull-request to master branch, as I want to use Rspec3.

@perlun
Copy link
Contributor

perlun commented Apr 26, 2017

@junaruga This one we shoud rebase on top of latest master, would be great to be able to use a current rspec with the project.

@terceiro
Copy link
Author

this port has been made more or less obsolete by commit 7536f85

I will just close this.

@terceiro terceiro closed this Apr 26, 2017
@terceiro
Copy link
Author

FTR, merging people's contributions with no attribution whatsoever is not a very nice thing to do. I am an old fart and don't really care in the long run, but I imagine someone new to free software/open source would be really bombed out by that.

@perlun
Copy link
Contributor

perlun commented Apr 26, 2017

@terceiro You're right, sorry about that. The project had gotten unmaintained for various reasons and @scepticulous did a catchup PR in #141. I rebased these commits onto current master when the repo was moved to the rack-test organization.

If you like, you can update the README.rdoc list of authors to include your name and submit a PR; I'll gladly accept it.

@junaruga
Copy link
Contributor

@perlun we have already supported rspec3 by below commit that you had merged.
7536f85

@perlun
Copy link
Contributor

perlun commented Apr 26, 2017

@junaruga Yes, I realize that, my bad. 😄

@terceiro
Copy link
Author

@perlun no worries. thanks for stepping up to maintain this in the first place!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants