Fix warning on usage #154
Closed
Fix warning on usage #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see this warning on every usage: ``` ~/.gem/jruby/2.3.1/gems/rack-test-0.6.3/lib/rack/test.rb:285: warning: instance variable @digest_username not initialized ```
|
Me too, please merge. I'm using Mike's fork atm :) |
perlun
approved these changes
Apr 26, 2017
|
@mperham thank you for your pull-request. @perlun So, I think that we do not need to merge this PR. At least I did not see the warning message on latest Travis CI's jruby test. @mperham @sandelius for that reason, I would close this PR. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see this warning on every usage: