-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allows symbol access to cookies #156
allows symbol access to cookies #156
Conversation
spec/rack/test/cookie_spec.rb
Outdated
jar = Rack::Test::CookieJar.new | ||
jar["value"] = "foo;abc" | ||
jar[:value].should == "foo;abc" | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move this closer to the other tests for Rack::Test::CookieJar
, around line 46 would make sense. Could you fix that @Anorlondo448 and also rebase on latest master
so we can see that Travis is still happy with this change in place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Anorlondo448 are you still available for the change that has been requested.
Otherwise I would just "re-implement" the change on the current master and open a PR that places the test at the right spot. What do you think @perlun ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scepticulous let's give it a few days first. If he doesn't seem to be around I'm fine with you closing this PR and rebasing the change on master
with the test at the right spot.
b8e2a64
to
1b7145b
Compare
1b7145b
to
2e750d9
Compare
@perlun , @scepticulous |
Thanks for your contribution @Anorlondo448! |
I think it's better if cookies method allows symbol access.
Symbol is available for
cookies method
in Ruby on Rails, but not available for testing.Because rack-test is used in Ruby on Rails, but not allow symbol access to cookies.
This problem is also written in
RUBY ON RAILS TUTORIAL (RAILS 5)
.(@chapter 9.3)
Ruby on Rails cookies method
https://github.com/rails/rails/blob/15a972e080d7712aa2eb04f21472398457d1439c/actionpack/lib/action_dispatch/middleware/cookies.rb#L315%23L317
I hope that this PR will be merged.
Regards.