Converts History.txt to markdown #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After discussing and agreeing on a convertion to markdown (see github issue rack#168 ) this change renames the file and cleans up the formatting. NOTE: the content stays untouched.
perlun
requested changes
May 17, 2017
History.md
Outdated
| Because #last_response is now a MockResponse instead of a Rack::Response, | ||
| #last_response.body now returns a string instead of an array. | ||
| Because #last_response is now a MockResponse instead of a Rack::Response, #last_response.body | ||
| now returns a string instead of an array. |
There was a problem hiding this comment.
Here we could also use backticks.
There was a problem hiding this comment.
jepp, i did it first but wass't sure if it would have enough value. I will update the PR accordingly. Thanks for the feedback.
According to the suggestions in the PR, more code snippets haven been marked as code for proper rendering.
|
@perlun PTAL |
perlun
approved these changes
May 19, 2017
alex-damian-negru
pushed a commit
to alex-damian-negru/rack-test
that referenced
this pull request
Apr 5, 2021
* Converts History.txt to markdown After discussing and agreeing on a convertion to markdown (see github issue rack#168 ) this change renames the file and cleans up the formatting. NOTE: the content stays untouched. * Improves code rendering According to the suggestions in the PR, more code snippets haven been marked as code for proper rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing and agreeing on a convertion to markdown
(see github issue #168 ) this change renames the file and
cleans up the formatting.
NOTE: the content stays untouched.