-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add how to install rack-test from github to README. #189
Add how to install rack-test from github to README. #189
Conversation
|
||
Or via Bundler: | ||
|
||
`gem "rack-test", require: "rack/test"` | ||
``` | ||
gem 'rack-test', require: 'rack/test' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed "rack/test" to 'rack/test'. This modification is because rubocop
is valid for the single quote code, and it looks more popular.
I tested like this.
And related document of Bundler is here. http://bundler.io/v1.15/git.html |
@@ -72,11 +72,22 @@ end | |||
|
|||
To install the latest release as a gem: | |||
|
|||
`gem install rack-test` | |||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modification is that I wanted to show same color for the section of Install as a gem
and Install via Bundler
.
<code>..</code>
, <pre>...</pre>
are displayed as different color on github markdown.
README.md
Outdated
|
||
``` | ||
gem 'rack-test', github: 'rack-test', branch: 'master' | ||
gem 'rack-test', github: 'rack-test', ref: 'a5aa1e5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could skip the second line. Most users will probably not go with a specific ref anyway, but rather a named branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I will remove the line.
To explain users about the way to install unreleased version.
9c643e7
to
5d95a4f
Compare
Rebased! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
(rebase again, then feel free to merge) |
Thanks! Merged. |
To explain users about the way to install unreleased version.
We are preparing next version release for
rack-test
.However users may want to use unreleased version now before that.
In that case, it is useful for users to know the way to install unreleased version.
You can see modified README here.
https://github.com/junaruga/rack-test/blob/feature/readme-install-from-github/README.md