Rubocop fixes

[perlun]

This makes the 👮 be happy.

A lot of this is just:

• rubocop -a (auto-fix)
• rubocop --auto-gen (generate todo config)

But, the good part about this is that we can now run Rubocop on each Travis build, to ensure that new code follows the Rubocop rules as defined in .rubocop.yml

[dennissivia]

Great job! I was about to ask if we already have a decision on style because of the code climate complains. This really enables us to have a solid base.
Thanks.

[junaruga]

Great job!
We will items in .rubocop_todo.yml one by one in the future, right?

I was about to ask if we already have a decision on style because of the code climate complains.

In my opinion, if possible, we should fix each code climate complains for each PR.
Because code climate complains only for modified lines of PR.

[junaruga]

In my opinion, if possible, we should fix each code climate complains for each PR.
Because code climate complains only for modified lines of PR.

The code climate may check only modified files. Not lines.

[perlun]

Thanks to you both!

@scepticulous

Great job! I was about to ask if we already have a decision on style because of the code climate complains. This really enables us to have a solid base.

Well, we don't really have a decision other than using the defaults as provided by Rubocop. I think most of these make sense, but there are cases where I typically deviate (you saw it mentioned in the PR in the .rubocop.yml change).

@junaruga

We will items in .rubocop_todo.yml one by one in the future, right?

Yes, that'd be the idea. If people have spare time and want to work on cleaning these issues up, they are very welcome to do so.

With this change in place, the Rubocop rules will run:

• On Travis
• On CodeClimate

That's of course a bit silly, but we can live with it for now. (It seems the codeclimate settings use a different version of Rubocop - if someone knows how to fix that, please do. OTOH, we could disable Rubocop on codeclimate since we already run it on Travis anyway.)