Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Added more badges #199

Merged
merged 2 commits into from
Aug 7, 2017
Merged

README.md: Added more badges #199

merged 2 commits into from
Aug 7, 2017

Conversation

perlun
Copy link
Contributor

@perlun perlun commented Aug 3, 2017

Sorry, once again a branch in this repo: it's just so convenient to edit straight in the GitHub UI. I promise to delete the branch afterwards. 😎

Should we have the version badge first or the downloads count first?

Sorry, once again a branch in this repo: it's just so convenient to edit straight in the GitHub UI. I promise to delete the branch afterwards. 😎
@perlun perlun self-assigned this Aug 3, 2017
@perlun perlun requested review from junaruga and dennissivia August 3, 2017 06:29
Copy link
Contributor

@junaruga junaruga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I do not like showing "Gem (download number).
That is something like showing an authority to get a credit from users.
In my opinion, showing an authority splits "rack-test" organization from users. And gains people who want to rely on the authority.

@junaruga
Copy link
Contributor

junaruga commented Aug 3, 2017

I did put your modified URL here.
https://github.com/rack-test/rack-test/blob/perlun-patch-1/README.md

I like Gem Version badge. :)

@junaruga
Copy link
Contributor

junaruga commented Aug 3, 2017

I promise to delete the branch afterwards.

Ok, I am fine :)

Should we have the version badge first or the downloads count first?

I like "the version badge first".

And I like not adding " downloads count".
Because the information itself is not useful for users. And I think that it is not good impression by some users.

@perlun
Copy link
Contributor Author

perlun commented Aug 4, 2017

And I like not adding " downloads count".
Because the information itself is not useful for users. And I think that it is not good impression by some users.

Fair point, I can understand how you mean. But OTOH, I think it does add some value. For me, as a user, researching "which gem should I chose for this task" - I think it's fair to say that a gem that has 98M downloads (!) has definitely more credibility and can be expected to work much better than something which has 100 downloads or even 1000 or 10000.

So I do think it adds some value, but I also respect your view on this. What does @scepticulous think?

@junaruga
Copy link
Contributor

junaruga commented Aug 4, 2017

For me, as a user, researching "which gem should I chose for this task"

I can understand your situation and the benefit. that is useful.
However linking to https://rubygems.org/gems/rack-test page from README is still good enough for the benefit?

Actually rails and rack do not put the download number in the page.
https://github.com/rails/rails
https://github.com/rack/rack

It's just my personal feeling.
Adding download number to README is like we are speaking people "our salary is NNNNN USD / year. It is not cool, is it?". It is not humility.

Also I like that we do not rely on believing numbers so much.
Technically we can increase the download number by a script program.
As an another fact, for example we can buy a follower number of Instagram, and ranking number in the magazine.
We should not promote this culture.

So I do think it adds some value, but I also respect your view on this. What does @scepticulous think?

OK. let's wait his opinion.

@dennissivia
Copy link

Sorry for the late feedback. First thanks for the improvement in general.
I thought about the download count and I actually agree with both of you.
However I tend to agree a little bit more with two poitns @junaruga made.

  1. I prefer the idea of humility (even though it is not actually a big issue with having the number)
  2. I actually don't like the number itself. My personal gems have an absurd high number of downloads considering the fact nobody uses it. But there are so many crawlers and tools and automated things that download a gem, that it is hard to know what it actually means. This might
    give the user the believe we are not aware of that or a false sense about the importance.
    Example my crypto toy gem with more than 37,000 downloads even though it is nothing somebody could actually use for something useful.

I hope I helped the discussion :)

...after peer review.
@perlun
Copy link
Contributor Author

perlun commented Aug 7, 2017

Thanks @scepticulous. You have very valid points. Thanks also @junaruga for the extended followup. I removed the download count now and will go with just the gem version (which makes sense, since it makes it very easy for people to know "which is the latest version", especially since we intend to ship more versions in the future. 😉)

Merging now.

@perlun perlun merged commit 421731c into master Aug 7, 2017
@perlun perlun deleted the perlun-patch-1 branch August 7, 2017 06:32
alex-damian-negru pushed a commit to alex-damian-negru/rack-test that referenced this pull request Apr 5, 2021
* README.md: Added more badges

Sorry, once again a branch in this repo: it's just so convenient to edit straight in the GitHub UI. I promise to delete the branch afterwards. 😎

* Removed download count

...after peer review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants