Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update History and README Supported platforms. #205

Merged
merged 1 commit into from
Nov 18, 2017
Merged

Update History and README Supported platforms. #205

merged 1 commit into from
Nov 18, 2017

Conversation

junaruga
Copy link
Contributor

@junaruga junaruga commented Nov 6, 2017

perlun
perlun requested changes Nov 13, 2017
View reviewed changes
Copy link
Contributor

@perlun perlun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things I think should be addressed before merge, but on the general whole, very nice @junaruga! 👍

History.md Outdated

* Minor enhancements
* Add a required_ruby_version of >= 2.2.2, that is same condition
with rack 2.0.1. (Samuel Giddins #194)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

", similar to rack 2.0.1" perhaps reads a bit simpler.

README.md Outdated
* 2.2.2+
* 2.3
* 2.4
* JRuby 9000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can say JRuby 9.1.+, we don't actually test towards JRuby 9.0.

README.md Outdated
* 2.4
* JRuby 9000

If you are using Ruby 1.8 or 1.9, use rack-test 0.6.3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ruby 1.8, 1.9 or JRuby 1.7, use..."

@junaruga junaruga force-pushed the feature/update-history branch from 3df7129 to b753db8 Compare November 14, 2017 11:22
@junaruga
Copy link
Contributor Author

@perlun thanks for the review. Those makes sense for me.
I updated and rebased ! 👍

perlun
perlun approved these changes Nov 17, 2017
View reviewed changes
Copy link
Contributor

@perlun perlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks really good now! You can go on and merge this, and publish the release.

@junaruga junaruga merged commit 84c2c3a into rack:master Nov 18, 2017
@junaruga junaruga deleted the feature/update-history branch November 18, 2017 22:23
@junaruga
Copy link
Contributor Author

ok! maybe tomorrow I will publish and release.

@junaruga
Copy link
Contributor Author

@perlun @scepticulous release v0.7.1 done!

https://rubygems.org/gems/rack-test
Ref: #206

@perlun
Copy link
Contributor

perlun commented Nov 20, 2017

@junaruga You changed your mind to make it 0.7.1 instead of 0.8.0, or was it just a mistake? The History.md file still says 0.8.0: https://github.com/rack-test/rack-test/blob/master/History.md#080--2017-11-19

I think 0.8.0 makes sense, since this release adds new functionality.

@junaruga
Copy link
Contributor Author

@perlun
I am sorry that 0.7.1 is my mistake.
I will remove 0.7.1 and release 0.8.0.

@junaruga
Copy link
Contributor Author

v0.8.0 release done.

First removed uploaded 0.7.1 gem and removed the tag, then installed v0.8.0.

$ gem yank rack-test -v 0.7.1
$ git tag -d v0.7.1
$ git push origin :refs/tags/v0.7.1

$ git revert 3195f4c7c32514ccc460e3240fcf990a6d566232
$ git push origin master

@perlun
Copy link
Contributor

perlun commented Nov 20, 2017

No worries! We can all make a mistake.

@junaruga
Copy link
Contributor Author

Sorry I missed below commit message too..

006aece

Revert "Release v0.7.1 (#206)"
This reverts commit 3195f4c.
Sorry v0.7.0 is my mistake. v0.8.0 is correct.

"v0.7.0 is my mistake" -> "Sorry v0.7.1 is my mistake"

@perlun
Copy link
Contributor

perlun commented Nov 20, 2017

Sorry I missed below commit message too..

😆 That's life, don't take it so hard.

alex-damian-negru pushed a commit to alex-damian-negru/rack-test that referenced this pull request Apr 5, 2021
@junaruga
Update History and README Supported platforms. (rack#205)
b30228d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perlun perlun perlun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junaruga @perlun