fix Legend overlapping problem #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ignore umd file and also I have tested the logic upto 18 records! |
FarajiA
reviewed
Oct 12, 2021
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "hedwig-monitoring-library", | |||
| "version": "1.4.0", | |||
| "version": "1.7.0", | |||
There was a problem hiding this comment.
These should be minor patch releases. e,g. 1.4.1.
FarajiA
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
It's usually not good practice to create a release from a feature branch. This can create all sorts of problems. For one the branch is not reviewed and can submitted without build tests. In the future releases from master branch only.
Can you make a test for the legends?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
See ticket here - https://jira.rax.io/browse/MNRVA-828
Description:
Fixed overlapping issue of text between legends.
fixed height issue for legends and if it is more than 6 then move to next line.
Testing:
use below version of hedwig inside minerva project and check the changes. you can also check the same on hedwig project as well.
Link :- https://github.com/racker/Hedwig/releases/tag/v1.7.0
Screenshots:
(if applicable)