Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating MAXLOAD, adding timeout. #130

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Deprecating MAXLOAD, adding timeout. #130

merged 1 commit into from
Oct 31, 2017

Conversation

tonyskapunk
Copy link
Contributor

@tonyskapunk tonyskapunk commented Oct 27, 2017 •
edited
Loading

  • Deprecated the use of MAXLOAD.
  • Timeout added to cronjobs with a default of 5m for most cases.

If any old configuration is making use of MAXLOAD, this will be simply ignored.

Fix #123

@tonyskapunk tonyskapunk mentioned this pull request Oct 27, 2017
Closed
@man-chung
Copy link
Contributor

Looks ok

@tonyskapunk
Copy link
Contributor Author

Thanks for looking @man-chung I'm going to rebase and give some time for any other reviewer

@LukeHandle
Copy link
Contributor

LGTM 👍

@tonyskapunk
Copy link
Contributor Author

merging into development

@tonyskapunk tonyskapunk merged commit 6768b6f into rackerlabs:development Oct 31, 2017
@tonyskapunk tonyskapunk deleted the issue123 branch November 3, 2017 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyskapunk @man-chung @LukeHandle