Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add DESTDIR to recap script on install. #196

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

tonyskapunk
Copy link
Contributor

By this change the functionality of DESTDIR is guaranteed for packaging or troubleshooting purposes only.

It is not expected that recap will work for normal operations when DESTDIR is defined when installing. This is due to the fact that LIBDIR variable inside recap will not make use of DESTDIR value, instead use the value of LIBDIR (from the Makefile or through environment).


DESTDIR support is commonly used in package creation. It is also helpful to users who want to understand what a given package will install where, and to allow users who don’t normally have permissions to install into protected areas to build and install before gaining those permissions.

[1] https://www.gnu.org/software/make/manual/html_node/DESTDIR.html


This change keeps the reference of LIBDIR in recap ignoring DESTIDIR:

$ make DESTDIR=/home/tonyskapunk/rpm/BUILDROOT/ PREFIX=/usr install -n | grep LIBDIR
sed -i.orig 's|^\s*\(declare\s\+-r\s\+LIBDIR=\).*$|\1"/usr/lib/recap"|' src/recap

Fix #195

@tonyskapunk
Copy link
Contributor Author

Merging in development

@tonyskapunk tonyskapunk merged commit f5f5bf0 into rackerlabs:development Feb 1, 2019
@tonyskapunk tonyskapunk deleted the libdir branch April 12, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant