fixed tf array parameters (#219)

Co-authored-by: edgar poce <eponce@onica.com>
rackspace · Apr 6, 2020 · 8f0ee9f · 8f0ee9f
1 parent 1b3e5f0
commit 8f0ee9f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/runway/module/terraform.py b/runway/module/terraform.py
@@ -1,5 +1,6 @@
 """Terraform module."""
 import copy
+import json
 import logging
 import os
 import re
@@ -189,7 +190,7 @@ def update_env_vars_with_tf_var_values(os_env_vars, tf_vars):
                            for (nestedkey, nestedval) in val.items()])
             )
         elif isinstance(val, list):
-            os_env_vars["TF_VAR_%s" % key] = '[' + ','.join(val) + ']'
+            os_env_vars["TF_VAR_%s" % key] = json.dumps(val)
         else:
             os_env_vars["TF_VAR_%s" % key] = val
     return os_env_vars

diff --git a/tests/module/test_terraform.py b/tests/module/test_terraform.py
@@ -12,7 +12,7 @@ def test_update_env_vars_with_tf_var_values(self):
         env_vars = update_env_vars_with_tf_var_values(
             {},
             {'foo': 'bar',
-             'list': ['test1', 'test2', 'test3'],
+             'list': ['foo', 1, True],
              'map': {'one': 'two',
                      'three': 'four'}}
         )
@@ -25,6 +25,6 @@ def test_update_env_vars_with_tf_var_values(self):
         #      'TF_VAR_map': '{ one = "two", three = "four" }'}
         # )
         self.assertTrue(env_vars['TF_VAR_foo'] == 'bar')
-        self.assertTrue(env_vars['TF_VAR_list'] == '[test1,test2,test3]')
+        self.assertTrue(env_vars['TF_VAR_list'] == '["foo", 1, true]')
         self.assertRegexpMatches(env_vars['TF_VAR_map'], r'one = "two"')  # noqa pylint: disable=deprecated-method
         self.assertRegexpMatches(env_vars['TF_VAR_map'], r'three = "four"')  # noqa pylint: disable=deprecated-method